Performance: Measure typing with the top toolbar enabled #57709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
the
[Status] Blocked
|
Size Change: 0 B Total Size: 1.69 MB ℹ️ View Unchanged
|
Mamaduka
force-pushed
the
try/perf-typing-with-top-toolbar
branch
from
3e5ab11
to
a6377c6
Compare
Mamaduka
changed the title
Mamaduka
removed
the
[Status] Blocked
Mamaduka
force-pushed
the
try/perf-typing-with-top-toolbar
branch
from
a6377c6
to
f2876f5
Compare
|
@ellatrix, @youknowriad, what do you think about including this metric? |
|
Yes, I made a PR for this before (#56115). I think we should add it. |
ellatrix
approved these changes
Jan 15, 2024
|
Sorry, somehow I miss that. Thanks for the review 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR adds typing perf metric when the top toolbar is enabled.
Why?
Similar to #56753.
The difference in metrics gives us a good picture of how much of the performance issues are coming from the Block Toolbar.
Testing Instructions
The perf tests should be green.