Performance: measure typing without inspector #56753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.72 MB ℹ️ View Unchanged
|
youknowriad
reviewed
Dec 4, 2023
| @@ -48,6 +49,9 @@ export interface WPPerformanceResults { | |||
| type?: number; | |||
| minType?: number; | |||
| maxType?: number; | |||
| typeWithoutInspector?: number; | |||
| minTypeWithoutInspector?: number; | |||
| maxTypeWithoutInspector?: number; | |||
There was a problem hiding this comment.
I'd remove the min/max to be honest, not that useful.
youknowriad
reviewed
Dec 4, 2023
| keyDownEvents[ i ] + keyPressEvents[ i ] + keyUpEvents[ i ] | ||
| ); | ||
| } | ||
| await type( firstParagraph, metrics, 'typeContainer' ); |
There was a problem hiding this comment.
I intentionally kept the way we compute "type in container" different than the regular "type".
One types and waits, the other doesn't wait. My thinking was that both of these metrics are useful but they are different. This PR reverts that.
There was a problem hiding this comment.
Reading the diff, maybe this has been reverted elsewhere?
There was a problem hiding this comment.
ok never mind, it was reverted before.
youknowriad
approved these changes
Dec 4, 2023
|
This had an impact on some numbers like "type in container", I guess this changed a bit how we compute the metric. Do you know what changed exactly? |
|
Also, why do you think this PR seem to have impacted "block select" metric as well? |
|
cc @WunderBart might also be interested in this PR |
@youknowriad, if closing the Editor Settings panel is persistent for the current editor instance, it will likely affect all the subsequent tests. It should be reopened after the test to keep the other numbers stable. edit: Nevermind, just noticed #56780 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a typing perf metric with the inspector panel closed.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast