-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ClipboardJS latest version and clean up focus loss workaround. #57156
Conversation
Size Change: +417 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
Flaky tests detected in fd7b448. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7247582461
|
Yeah, sounds good. I'm not actively working on that PR at the moment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed the testing instructions and both copy buttons remain focused and the copied content is correct.
Thank you all for the review and feedback. |
Fixes #57154
What?
Upgrades ClipboardJS to 2.0.11.
Removes a focus loss workaround.
Why?
ClipboardJS 2.0.11 includes a fix for a focus loss that makes our workaround no longer necessary.
WordPress Core already uses 2.0.11.
How?
Upgrades ClipboardJS.
Removes focus loss fix from
useCopyToClipboard
.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast