Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ClipboardJS latest version #57154

Closed
afercia opened this issue Dec 18, 2023 · 0 comments · Fixed by #57156
Closed

Use ClipboardJS latest version #57154

afercia opened this issue Dec 18, 2023 · 0 comments · Fixed by #57156
Assignees
Labels
[Package] Compose /packages/compose [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Enhancement A suggestion for improvement.

Comments

@afercia
Copy link
Contributor

afercia commented Dec 18, 2023

Description

ClipboardJS latest version is 2.0.11 see https://github.com/zenorocha/clipboard.js/releases/tag/v2.0.11 released 1 year and a half ago.
It includes a fix for a focus loss issue that was reported upstream at zenorocha/clipboard.js#680

In #23994 / #24022 we introduced a workaround that is no longer necessary. Worth noting packages/compose/src/hooks/use-copy-on-click/index.js is now deprecated. The same workaround was ported to the new hook useCopyToClipboard.

WordPress Core already uses ClipboardJS 2.0.11.

Step-by-step reproduction instructions

N/A

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended [Type] Enhancement A suggestion for improvement. [Package] Compose /packages/compose labels Dec 18, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Compose /packages/compose [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant