Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override all the labels of the pattern categories taxonomy #57094

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Override all the labels of the pattern categories taxonomy #57094

merged 3 commits into from
Dec 20, 2023

Conversation

youknowriad
Copy link
Contributor

closes #57076

What?

The site editor has been updated to use the normal post taxonomies component, this highlighted the fact that the "pattern categories" taxonomy didn't have all the labels defined properly. This PR fixes that.

Testing Instructions

  • Open a synced pattern in the site editor
  • Notice the "pattern categories" panel on the editor sidebar
  • It says "Add pattern category" rather than "Add tag"

@youknowriad youknowriad added the [Type] Bug An existing feature does not function as intended label Dec 15, 2023
@youknowriad youknowriad self-assigned this Dec 15, 2023
@github-actions GitHub Actions
Copy link

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/compat/wordpress-6.5/block-patterns.php
❔ lib/load.php

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 15, 2023 •
edited
Loading

Flaky tests detected in 64503d1.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7246591694
📝 Reported issues:

richtabor
richtabor reviewed Dec 15, 2023
View reviewed changes
lib/compat/wordpress-6.5/block-patterns.php Outdated
'labels' => array(
'name' => _x( 'Pattern Categories', 'taxonomy general name' ),
'singular_name' => _x( 'Pattern Category', 'taxonomy singular name' ),
'add_new_item' => __( 'Add New Pattern Category' ),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about making this "Add new category" instead? It's a bit duplicative as-is:

CleanShot 2023-12-15 at 17 14 36

lib/compat/wordpress-6.4/block-patterns.php Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just double-checking it's ok to remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, it's fine, it was moved.

@richtabor richtabor mentioned this pull request Dec 15, 2023
Open
@talldan talldan requested a review from glendaviesnz December 18, 2023 02:07
ntsekouras
ntsekouras approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

lib/compat/wordpress-6.5/block-patterns.php Outdated Show resolved Hide resolved
@youknowriad @ntsekouras
Fix comment
3488463 
Co-authored-by: Nik Tsekouras <[email protected]>
@youknowriad youknowriad enabled auto-merge (squash) December 20, 2023 06:53
@ntsekouras ntsekouras mentioned this pull request Dec 20, 2023
Merged
@youknowriad youknowriad merged commit b924779 into trunk Dec 20, 2023
50 of 51 checks passed
@youknowriad youknowriad deleted the fix/pattern-category-labels branch December 20, 2023 07:20
@github-actions github-actions bot added this to the Gutenberg 17.4 milestone Dec 20, 2023
@bph bph added [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced labels Dec 27, 2023
@getdave getdave added the Needs PHP backport Needs PHP backport to Core label Jan 15, 2024
@getdave getdave mentioned this pull request Jan 18, 2024
Closed
@youknowriad youknowriad mentioned this pull request Jan 23, 2024
Closed
@youknowriad youknowriad added Backported to WP Core Pull request that has been successfully merged into WP Core and removed Needs PHP backport Needs PHP backport to Core labels Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richtabor richtabor richtabor left review comments

@ntsekouras ntsekouras ntsekouras approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

@glendaviesnz glendaviesnz Awaiting requested review from glendaviesnz

Assignees

@youknowriad youknowriad

Labels
Backported to WP Core Pull request that has been successfully merged into WP Core [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 17.4
Development

Successfully merging this pull request may close these issues.

Pattern categories referenced as tags in site editor post taxonomies panel
5 participants
@youknowriad @richtabor @ntsekouras @bph @getdave