Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override all the labels of the pattern categories taxonomy #57094

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Override all the labels of the pattern categories taxonomy #57094

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7000577
Override all the labels of the pattern categories taxonomy
youknowriad Dec 15, 2023
64503d1
Simpler label
youknowriad Dec 18, 2023
3488463
Fix comment
youknowriad Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 0 additions & 36 deletions lib/compat/wordpress-6.4/block-patterns.php
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just double-checking it's ok to remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, it's fine, it was moved.

This file was deleted.

47 changes: 47 additions & 0 deletions lib/compat/wordpress-6.5/block-patterns.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,50 @@ function gutenberg_register_media_pattern_categories() {
);
}
add_action( 'init', 'gutenberg_register_media_pattern_categories' );

/**
* Adds a new taxonomy for organizing user created patterns.
*
* Note: This should be removed when the minimum required WP version is >= 6.4.
*
* @see https://github.com/WordPress/gutenberg/pull/53163
youknowriad marked this conversation as resolved.
Show resolved Hide resolved
*
* @return void
*/
function gutenberg_register_taxonomy_patterns() {
$args = array(
'public' => false,
'publicly_queryable' => false,
'hierarchical' => false,
'labels' => array(
'name' => _x( 'Pattern Categories', 'taxonomy general name' ),
'singular_name' => _x( 'Pattern Category', 'taxonomy singular name' ),
'add_new_item' => __( 'Add New Pattern Category' ),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about making this "Add new category" instead? It's a bit duplicative as-is:

CleanShot 2023-12-15 at 17 14 36

'add_or_remove_items' => __( 'Add or remove pattern categories' ),
'back_to_items' => __( '← Go to pattern categories' ),
'choose_from_most_used' => __( 'Choose from the most used pattern categories' ),
'edit_item' => __( 'Edit Pattern Category' ),
'item_link' => __( 'Pattern Category Link' ),
'item_link_description' => __( 'A link to a pattern category.' ),
'items_list' => __( 'Pattern Categories list' ),
'items_list_navigation' => __( 'Pattern Categories list navigation' ),
'new_item_name' => __( 'New Pattern Category Name' ),
'no_terms' => __( 'No pattern categories' ),
'not_found' => __( 'No pattern categories found.' ),
'popular_items' => __( 'Popular Pattern Categories' ),
'search_items' => __( 'Search Pattern Categories' ),
'separate_items_with_commas' => __( 'Separate pattern categories with commas' ),
'update_item' => __( 'Update Pattern Category' ),
'view_item' => __( 'View Pattern Category' ),
),
'query_var' => false,
'rewrite' => false,
'show_ui' => true,
'_builtin' => true,
'show_in_nav_menus' => false,
'show_in_rest' => true,
'show_admin_column' => true,
);
register_taxonomy( 'wp_pattern_category', array( 'wp_block' ), $args );
}
add_action( 'init', 'gutenberg_register_taxonomy_patterns' );
1 change: 0 additions & 1 deletion lib/load.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ function gutenberg_is_experiment_enabled( $name ) {
// WordPress 6.4 compat.
require __DIR__ . '/compat/wordpress-6.4/blocks.php';
require __DIR__ . '/compat/wordpress-6.4/block-hooks.php';
require __DIR__ . '/compat/wordpress-6.4/block-patterns.php';
require __DIR__ . '/compat/wordpress-6.4/script-loader.php';
require __DIR__ . '/compat/wordpress-6.4/kses.php';

Expand Down
Loading