Fix flaky Navigation focus mode test #57016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Code Quality
|
Size Change: +840 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in d750629. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7206975193
|
|
@kevin940726 Tests pass but how to test if it's flaky on the next run? What workflow would you recommend? |
|
I think this test will fail once every time but pass on the second try. We use A quick fix will be moving the setup before we visit the site editor. |
I honestly don't know how this got jumbled up. Must have been copy/paste or when I was reorganising the tests. Great spot. Thank you! |
artemiomorales
pushed a commit
that referenced
this pull request
Jan 4, 2024
* Add missing assertion * Test expect url * Do setup before entering editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow up to #56871 to try and fix the flaky test.
Closes #57017
Why?
Flaky tests are annoying.
How?
Find fix.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast