-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic test coverage for Navigation Menu editing mode #56871
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,155 @@ | ||
/** | ||
* WordPress dependencies | ||
*/ | ||
const { test, expect } = require( '@wordpress/e2e-test-utils-playwright' ); | ||
|
||
test.describe( 'Editing Navigation Menus', () => { | ||
test.beforeAll( async ( { requestUtils } ) => { | ||
await requestUtils.activateTheme( 'emptytheme' ); | ||
} ); | ||
|
||
test.afterEach( async ( { requestUtils } ) => { | ||
await requestUtils.deleteAllMenus(); | ||
} ); | ||
|
||
test( 'it should lock the root Navigation block in the editor', async ( { | ||
admin, | ||
page, | ||
pageUtils, | ||
requestUtils, | ||
editor, | ||
} ) => { | ||
await test.step( 'Manually browse to focus mode for a Navigation Menu', async () => { | ||
// We could Navigate directly to editing the Navigation Menu but we intentionally do not do this. | ||
// | ||
// Why? To provide coverage for a bug that caused the Navigation Editor behaviours to fail | ||
// only when navigating through the editor screens (rather than going directly to the editor by URL). | ||
// See: https://github.com/WordPress/gutenberg/pull/56856. | ||
// | ||
// Example (what we could do): | ||
// await admin.visitSiteEditor( { | ||
// postId: createdMenu?.id, | ||
// postType: 'wp_navigation', | ||
// } ); | ||
// | ||
await admin.visitSiteEditor(); | ||
|
||
// create a Navigation Menu called "Test Menu" using the REST API helpers | ||
const createdMenu = await requestUtils.createNavigationMenu( { | ||
title: 'Primary Menu', | ||
content: | ||
'<!-- wp:navigation-link {"label":"WordPress","type":"custom","url":"http://www.wordpress.org/","kind":"custom"} /-->', | ||
} ); | ||
|
||
// Add another so we get a list of Navigation menus in the editor. | ||
await requestUtils.createNavigationMenu( { | ||
title: 'Another One', | ||
content: | ||
'<!-- wp:navigation-link {"label":"Another Item","type":"custom","url":"http://www.wordpress.org/","kind":"custom"} /-->', | ||
} ); | ||
|
||
const editorSidebar = page.getByRole( 'region', { | ||
name: 'Navigation', | ||
} ); | ||
|
||
await editorSidebar | ||
.getByRole( 'button', { | ||
name: 'Navigation', | ||
} ) | ||
.click(); | ||
|
||
// Wait for list of Navigations to appear. | ||
await expect( | ||
editorSidebar.getByRole( 'heading', { | ||
name: 'Navigation', | ||
level: 1, | ||
} ) | ||
).toBeVisible(); | ||
|
||
await editorSidebar | ||
.getByRole( 'button', { | ||
name: 'Primary Menu', | ||
} ) | ||
.click(); | ||
Check failure on line 73 in test/e2e/specs/site-editor/navigation-editor.spec.js GitHub Actions / Playwright - 6[chromium] › site-editor/navigation-editor.spec.js:15:2 › Editing Navigation Menus › it should lock the root Navigation block in the editor
|
||
|
||
await expect( page ).toHaveURL( | ||
`wp-admin/site-editor.php?postId=${ createdMenu?.id }&postType=wp_navigation` | ||
); | ||
|
||
// Wait for list of Navigations to appear. | ||
editorSidebar.getByRole( 'heading', { | ||
name: 'Primary Menu', | ||
level: 1, | ||
} ); | ||
|
||
// Switch to editing the Navigation Menu | ||
await editorSidebar | ||
.getByRole( 'link', { | ||
name: 'Edit', | ||
} ) | ||
.click(); | ||
} ); | ||
getdave marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
await test.step( 'Check Navigation block is present and locked', async () => { | ||
// Open List View. | ||
await pageUtils.pressKeys( 'access+o' ); | ||
|
||
const listView = page | ||
.getByRole( 'region', { | ||
name: 'List View', | ||
} ) | ||
.getByRole( 'treegrid', { | ||
name: 'Block navigation structure', | ||
} ); | ||
|
||
await expect( listView ).toBeVisible(); | ||
|
||
const navBlockNode = listView.getByRole( 'link', { | ||
name: 'Navigation (locked)', | ||
exact: true, | ||
} ); | ||
|
||
// The Navigation block should be present and locked. | ||
await expect( navBlockNode ).toBeVisible(); | ||
|
||
// The block should have no options menu. | ||
await expect( | ||
listView.getByRole( 'button', { | ||
name: 'Options for Navigation', | ||
exact: true, | ||
} ) | ||
).toBeHidden(); | ||
|
||
// Select the Navigation block. | ||
await navBlockNode.click(); | ||
} ); | ||
|
||
await test.step( 'Check Navigation block has no controls other than editable list view', async () => { | ||
// Open the document settings sidebar | ||
await editor.openDocumentSettingsSidebar(); | ||
|
||
const sidebar = page.getByRole( 'region', { | ||
name: 'Editor settings', | ||
} ); | ||
|
||
await expect( sidebar ).toBeVisible(); | ||
|
||
// Check that the `Menu` control is visible. | ||
// This is effectively the contents of the "List View" tab. | ||
await expect( | ||
sidebar.getByRole( 'heading', { name: 'Menu', exact: true } ) | ||
).toBeVisible(); | ||
|
||
// Check the standard tabs are not present. | ||
await expect( | ||
sidebar.getByRole( 'tab', { name: 'List View' } ) | ||
).toBeHidden(); | ||
await expect( | ||
sidebar.getByRole( 'tab', { name: 'Settings' } ) | ||
).toBeHidden(); | ||
await expect( | ||
sidebar.getByRole( 'tab', { name: 'Styles' } ) | ||
).toBeHidden(); | ||
} ); | ||
} ); | ||
} ); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we missed this 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test still seems flaky. I'll take another look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to see if I can get the flaky test to happen in #57016