Add mobile OfflineStatus component #56848
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekblank
added
[Type] Enhancement
|
Size Change: -14.4 kB (-1%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
dcalhoun
force-pushed
the
feat/connectivity-status
branch
from
98b6977
to
aadf8c6
Compare
dcalhoun
reviewed
Dec 7, 2023
There was a problem hiding this comment.
Overall, the changes look good and the status indicator correctly shows up when the network status changes. 🎉
I noted the status appears invisible on Android when dark mode is enabled. Do you see this as well?
Android Dark Mode Screenshot
Also, I'm not sure if my eyes are playing tricks on me or if the status text and icon are not vertically centered. WDYT?
Status Vertically Centered
.../src/main/java/org/wordpress/mobile/ReactNativeGutenbergBridge/GutenbergBridgeJS2Parent.java
Outdated
Show resolved
Hide resolved
Co-authored-by: ntsekouras <[email protected]>
- @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected]
Co-authored-by: Riad Benguella <[email protected]>
* `FontSizePicker`: Add opt-in prop for 40px default size * Update button when __next40pxDefaultSize is true * Update changelog
…wrapper (#56335) - Combine `<BlockContextualToolbar />` into `<BlockToolbar />`. This brings all the necessary functionality for `<BlockToolbar />` to be used, mainly by wrapping it in a `<NavigableToolbar />`. - Remove `<BlockContextualToolbar />`. This is no longer needed, and was originally intended for Contextual to mean Popover. - Replace usage of `<BlockContextualToobar />` in edit-site, edit-post, edit-widget, etc headers with `<BlockToolbar />` - Refactor `<SelectedBlockTools />` to become `<BlockToolbarPopover />` to better reflect its purpose. - Add `<PrivateBlockToolbar />` with new props of `__experimentalInitialIndex`, `__experimentalOnIndexChange`, and `focusOnMount`. - Export `<BlockToolbar />` from `<PrivateBlockToolbar />` with locked `__experimentalInitialIndex`, `__experimentalOnIndexChange`, and `focusOnMount` as `undefined`. Public API props are `hideDragHandles` and `variant` with a default of `unstyled`. - Remove concept of `isFixed` from the `<BlockToolbar />`. The styles of the current small-screen fixed toolbar will become the default. The popover and top toolbars will have its own CSS overrides applied. - Split `<BlockToolbarPopover />` and `<BlockBreadcrumbPopover />` into separate components for simplicity. - Top Toolbar now means. You have to implement the `<BlockToolbar />` on your own.
derekblank
force-pushed
the
rnmobile/connect-offline-status-component
branch
from
412ffe3
to
50571da
Compare
|
Flaky tests detected in dc54432. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7161686544
|
It was deprecated in 5.8 and slated to be removed in 6.3.
* `BorderControl`: Fix button styles * Add __next40pxDefaultSize to Button when BorderControl has large size * Update changelog * Remove explicit return leftover from unused changes
I did not note this, but it appears like it may be theme-based as I noted the editor background is not dark in your screenshot. I can take a look, however. What theme were you using? Both examples in this screenshot are using Quadrat: 
|
I think it's the icon that is not correct. I used a placeholder icon I found for free, but was intending to replace it after we received some design feedback. I'll seek that out now and replace it here as we're leaving the PR open. |
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/compat/wordpress-6.5/html-api/class-gutenberg-html-attribute-token-6-5.php ❔ lib/compat/wordpress-6.5/html-api/class-gutenberg-html-span-6-5.php ❔ lib/compat/wordpress-6.5/html-api/class-gutenberg-html-tag-processor-6-5.php ❔ lib/compat/wordpress-6.5/html-api/class-gutenberg-html-text-replacement-6-5.php ❔ lib/experimental/interactivity-api/class-wp-directive-processor.php ❔ lib/load.php |
derekblank
removed request for
draganescu,
adamziel,
spacedmonkey,
Mamaduka,
juanmaguitar,
getdave,
noisysocks,
talldan,
ntwb,
ajitbohra,
ryanwelcher,
nerrad,
luisherranz,
ellatrix,
ndiego,
geriux,
ajlende,
artemiomorales,
michalczaplinski,
dmsnell,
DAreRodz,
kevin940726,
tellthemachines,
fluiddot and
fabiankaegy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a mobile component to display a visual indicator when working offline within the mobile editor. (Note: the functionality to subscribe to network status will be handled in a separate PR.)
Why?
Overall, to improve the user's experience when uploading media.
Addresses:
How?
Adds OfflineStatus component and associated icon/style files.
Testing Instructions
Applying the test patch will display the component within the editor when offline.
Test Diff
Screenshots or screencast