Editor: Move the device type state to the editor package #56866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
youknowriad
requested review from
ellatrix,
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
Size Change: +84 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in c4bf3dd. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7128834515
|
ellatrix
reviewed
Dec 7, 2023
| @@ -189,7 +185,7 @@ export default function DocumentTools( { | |||
| /* translators: button label text should, if possible, be under 16 characters. */ | |||
| label={ __( 'Zoom-out View' ) } | |||
| onClick={ () => { | |||
| setPreviewDeviceType( 'Desktop' ); | |||
| setDeviceType( 'Desktop' ); | |||
There was a problem hiding this comment.
Having an API like this with Capital letters seems a bit weird, but I guess we can alway lowercase this later if needed.
There was a problem hiding this comment.
Just mentioning it since we're stabilising.
There was a problem hiding this comment.
I can switch but it's going to have an impact on the deprecations, just make them harder. So maybe just keep that for now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #52632
What?
This PR centralizes the selected "device" state into the "editor" store, unifying and stabilizing the selectors from edit-post and edit-site. The next steps is going to be the UI to change the device and also the resizing styles that are added when you change devices.
Testing Instructions
No functional changes, just code being moved around.