Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Schedule Panel: Remove text overflow ellipsis #56319

Merged
merged 5 commits into from
Nov 20, 2023
Merged

Post Schedule Panel: Remove text overflow ellipsis #56319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1887a26
Post Schedule Panel: Remove text overflow ellipsis
youknowriad Nov 20, 2023
059cc97
Fix alignments
youknowriad Nov 20, 2023
5a5dc78
Remove conditional style
youknowriad Nov 20, 2023
c94e615
Add a line height
youknowriad Nov 20, 2023
6d16862
Use computation to explain the logic of the styles
youknowriad Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/editor/src/components/post-panel-row/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,16 @@
.editor-post-panel__row {
width: 100%;
justify-content: flex-start;
align-items: flex-start;
min-height: $button-size;
justify-content: flex-start !important;
align-items: flex-start !important;
Comment on lines +4 to +5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe explain why this needs to be conditional now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good remark, the conditional style is actually not needed now.

}

.editor-post-panel__row-label {
width: 30%;
flex-shrink: 0;
min-height: $button-size;
display: flex;
align-items: center;
}

.editor-post-panel__row-control {
Expand Down
10 changes: 7 additions & 3 deletions packages/editor/src/components/post-schedule/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,15 @@
}
}

.editor-post-schedule__dialog-toggle {
.editor-post-schedule__dialog-toggle.components-button {
display: block;
max-width: 100%;
overflow: hidden;
text-align: left;
text-overflow: ellipsis;
white-space: nowrap;
white-space: unset;
height: auto;

// The line height + the padding should be the same as the button size.
padding: ( ( $button-size - $grid-unit-20 ) / 2 ) 12px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this introduced a deprecation warning when building Gutenberg. Tiny follow-up PR over in #56412 🙂

line-height: $grid-unit-20;
}
Loading