Post Schedule Panel: Fix Sass deprecation warning for division #56412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
the
[Type] Code Quality
|
Size Change: 0 B Total Size: 1.7 MB ℹ️ View Unchanged
|
|
didn't know about this, thanks. |
andrewserong
deleted the
fix/post-schedule-button-style-sass-deprecation-warning
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow-up to #56319 to fix a Sass deprecation warning about the
/character being used for division. The warning says to usemath.divinstead.Why?
To fix the warning from appearing when building Gutenberg (it shows when you run
npm run devlocally).How?
Use the recommended replacement math.div
Testing Instructions
Just double-check that the calculated padding is the same as in #56319. I see the following locally:
10pxwhich is a result of the button size (36px) minus the 20 grid unit size (16px).Testing Instructions for Keyboard
Screenshots or screencast
This warning should no longer appear when building Gutenberg: