DataViews: remove title from pages #56241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
requested review from
ntsekouras,
youknowriad,
jameskoster,
SaxonF and
jorgefilipecosta
oandregal
added
[Type] Experimental
|
Size Change: -13 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Nov 17, 2023
This was referenced Nov 17, 2023
|
Related threads #56199 and #56157 (comment) I'd like to grab @jameskoster @jasmussen @SaxonF thoughts before landing this one, to make sure we are in sync. |
|
cc @pablohoneyhoney as you expressed the desire to remove this as well. |
|
Did we check the impact this PR has on the hierarchy of the heading in the HTML page. |
|
In #56199 I proposed making this title match the view name which – to Riad's point – would result in:
That said I wouldn't object to removing it. In terms of communicating the current page, the active menu item might be adequate, and a hidden title could be used if that's a requirement. I would say that a title area provides a neat space for an "Add new" button though, which we're likely to need in the future. |
|
I'm in favour of keeping the page title (View name) with CTA for adding new page + secondary view actions. It's the same for any sub page that we may have e.g. settings pages that have an active sidebar menu item along with page title |
This was referenced Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #55083
What?
Removes the title from the pages.
Why?
The page title is redundant, as the sidebar already anchors the user, telling them where they are. Removing the title leaves also more space for the main interaction of the page (filtering, search, pagination, etc.).
How?
Removes the title from the
<Page>component.Testing Instructions