-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataViews: Frame title should match current view #56199
Comments
I actually have a PR to remove it at #56241 :) Related thread #56157 (comment)
|
Reopening. This one is about the title of the white content area, #59011 was about the sidebar titles. |
Another reason to close this one; Pages and Templates data views are currently inconsistent with Patterns. As you navigate through Pattern categories the frame header updates accordingly, unlike Page and Templates. |
Hi @jameskoster , I have raised a PR for this considering the comment you mentioned over here -#56241 (comment). So, can you please review the PR at your convenience. Not related to the above PR, but just adding a personal observation over here - Please ignore! I found this issue - #60468 This one states exactly the same thing. 😅 As you can see in the below video, when I change the view to suppose Draft and then clear out the Draft filter, still the active view remains as Draft. Because of this the left sidebar and also the subtitle I added remains unchanged. Thinking about this I think this is what is expected, that's because the views are meant to be kind of preset filters. So, anyone can select a preset filter and then edit the filters, but still ultimately we are in that preset filter only. So, yeah it makes sense. But just wanted to put this here. Screen.Recording.2024-05-25.at.7.37.04.PM.movThanks! |
For instance in this view:
The frame title should be "Drafts" instead of "Pages":
The text was updated successfully, but these errors were encountered: