Patterns: Fix All Patterns category default display #54721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Regression
|
Size Change: 0 B Total Size: 1.62 MB ℹ️ View Unchanged
|
aaronrobertshaw
added
the
Backport to Gutenberg RC
mikachan
pushed a commit
that referenced
this pull request
Sep 22, 2023
|
I just cherry-picked this PR to the release/16.7 branch to get it included in the next release: 93dd8a6 |
mikachan
removed
the
Backport to Gutenberg RC
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
What?
Fixes regression in "All Patterns" display when it is the default category before a selection is made.
Why?
It's broken and doesn't match the correct count next to the All Patterns category in the sidebar navigation.
How?
Assign the original default pattern type back on the patterns page.
DEFAULT_TYPEset hereDEFAULT_TYPEwas originally set herePATTERN_TYPES.themevalue matches the original default so that's what it was switched toTesting Instructions
Screenshots or screencast
Screen.Recording.2023-09-22.at.7.26.40.pm.mp4
Screen.Recording.2023-09-22.at.7.37.07.pm.mp4