update empty patterns #54642
Closed
update empty patterns #54642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +150 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
aaronrobertshaw
previously approved these changes
Sep 20, 2023
There was a problem hiding this comment.
Nice work @SaxonF 👍
This PR tests well for me and is a drastic improvement over the simple "no patterns" message.
✅ Creating patterns from dropdown still works
✅ Triggering pattern creation from new empty state works
✅ Empty pattern state displays well when reached via dodgy URL, unmatched filters etc
My one question is should we update this to trigger creating a template part when you are in an empty template part category (e.g. via searching)?
I'm happy to approve this now though as we could refine the template part aspect in a follow-up.
|
Flaky tests detected in 2e9f032. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6387120723
|
|
Sorry, accidentally closed this! Reopening. I noticed when testing that the 'All Patterns' category appears selected on the left when visiting the patterns page: Something about this doesn't feel right to me. If you click on 'All Patterns' at this point you end up with a different view, even though it feels like I had the same thing selected as before. |
aaronrobertshaw
force-pushed
the
update/empty-patterns
branch
from
555412d
to
2e9f032
Compare
After some constants were refactored, a regression was introduced causing the filters not to show. This was fixed in #54721. I could replicate that issue on this branch, which was resolved after rebasing this PR. |
aaronrobertshaw
added
[Type] Enhancement
|
Now #54906 has merged we'll need to update the e2e tests that currently check for |
|
@SaxonF This is now looking good to me with that fix. There's one potential convenience feature for users that came to mind, it might be good for the new pattern modal to be pre-filled with the selected category and sync status. What do you think? |
There's a draft PR for an alternate duplication flow that reuses the create pattern modal and pre-populates some fields. So it has some overlap with this suggestion. Could it be a separate follow-up? |
Absolutely 👍 |
kevin940726
reviewed
Oct 16, 2023
| <Icon icon={ symbol } /> | ||
| <VStack spacing={ 3 } alignment="center"> | ||
| <Heading level={ 4 } as="h2"> | ||
| { __( 'Create a pattern' ) } |
There was a problem hiding this comment.
I wonder if we should still show text suggesting no patterns for accessibility reasons?
|
I believe this screen is being replaced by an admin view, so is this update still planned to be included in WordPress 6.5? |
t-hamano
dismissed
aaronrobertshaw’s stale review
To prevent unintentional merging
|
With 58482 merged, should this be closed? |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pattern-empty.mp4
What?
Updates the empty state when no patterns exist.
Why?
Direct people to create their first pattern.
#53287
How?
Updates the no-patterns component and adds a renderTrigger prop to the AddNewPattern component.
Testing Instructions