Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Post: Refactor class names in More Menu component #5218

Merged
merged 1 commit into from
Feb 23, 2018
Merged

Edit Post: Refactor class names in More Menu component #5218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/menu-items/menu-items-group.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,12 @@ export function MenuItemsGroup( {
}

const labelId = `components-menu-items-group-label-${ instanceId }`;
const classNames = classnames( className, 'components-menu-items-group' );
const classNames = classnames( className, 'components-menu-items__group' );

return (
<div className={ classNames }>
{ label &&
<div className="components-menu-items-group__label" id={ labelId }>{ label }</div>
<div className="components-menu-items__group-label" id={ labelId }>{ label }</div>
}
<NavigableMenu orientation="vertical" aria-labelledby={ labelId }>
{ menuItems }
Expand Down
4 changes: 2 additions & 2 deletions components/menu-items/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
.components-menu-items-group {
.components-menu-items__group {
width: 100%;
padding: 10px;
}

.components-menu-items-group__label {
.components-menu-items__group-label {
margin-bottom: 10px;
color: $dark-gray-300;
}
Expand Down
4 changes: 2 additions & 2 deletions components/menu-items/test/__snapshots__/menu-items-group.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@

exports[`MenuItemsGroup should match snapshot 1`] = `
<div
className="components-menu-items-group"
className="components-menu-items__group"
>
<div
className="components-menu-items-group__label"
className="components-menu-items__group-label"
id="components-menu-items-group-label-1"
>
My group
Expand Down
2 changes: 1 addition & 1 deletion edit-post/components/header/more-menu/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
}

.edit-post-more-menu__content {
.components-menu-items-group:not(:last-child) {
.components-menu-items__group:not(:last-child) {
border-bottom: 1px solid $light-gray-500;
}
}