Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit Post: Refactor class names in More Menu component #5218

Merged
merged 1 commit into from
Feb 23, 2018
Merged

Edit Post: Refactor class names in More Menu component #5218

merged 1 commit into from
Feb 23, 2018

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Feb 23, 2018

Description

Related comment from @aduth #5161 (comment):

This should be .components-menu-items__group

https://github.com/WordPress/gutenberg/blob/master/docs/coding-guidelines.md#css

This PR addresses it.

Types of changes

Refactoring

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code has proper inline documentation.

@gziolo gziolo added the [Feature] UI Components Impacts or related to the UI component system label Feb 23, 2018
@gziolo gziolo self-assigned this Feb 23, 2018
@gziolo gziolo requested a review from aduth February 23, 2018 13:28
@gziolo gziolo mentioned this pull request Feb 23, 2018
Merged
3 tasks
@gziolo gziolo merged commit 01ea7d8 into master Feb 23, 2018
@gziolo gziolo deleted the update/more-menu-class-name branch February 23, 2018 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduth aduth aduth approved these changes

Assignees

@gziolo gziolo

Labels
[Feature] UI Components Impacts or related to the UI component system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gziolo @aduth