Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gettext content when translating 'Header'. #51066

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Add gettext content when translating 'Header'. #51066

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5af86a
Add gettext content when translating 'Header'.
gonzomir May 29, 2023
4d197f6
Oops, add import for _x().
gonzomir Sep 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/interface/src/components/interface-skeleton/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {
__unstableUseNavigateRegions as useNavigateRegions,
__unstableMotion as motion,
} from '@wordpress/components';
import { __ } from '@wordpress/i18n';
import { __, _x } from '@wordpress/i18n';
import { useMergeRefs } from '@wordpress/compose';

/**
Expand Down Expand Up @@ -59,7 +59,7 @@ function InterfaceSkeleton(

const defaultLabels = {
/* translators: accessibility text for the top bar landmark region. */
header: __( 'Header' ),
header: _x( 'Header', 'header landmark area' ),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gonzomir thank you for this enhancement 👍 We are missing the import of the _x function in import { __ } from '@wordpress/i18n'; line 14, but other than that the PR looks good.

/* translators: accessibility text for the content landmark region. */
body: __( 'Content' ),
/* translators: accessibility text for the secondary sidebar landmark region. */
Expand Down
Loading