Add gettext content when translating 'Header'. #51066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priethor
added
[Type] Enhancement
| @@ -59,7 +59,7 @@ function InterfaceSkeleton( | |||
|
|
|||
| const defaultLabels = { | |||
| /* translators: accessibility text for the top bar landmark region. */ | |||
| header: __( 'Header' ), | |||
| header: _x( 'Header', 'header landmark area' ), | |||
There was a problem hiding this comment.
Hi @gonzomir thank you for this enhancement 👍 We are missing the import of the _x function in import { __ } from '@wordpress/i18n'; line 14, but other than that the PR looks good.
|
@jorgefilipecosta Sorry for taking me so long to add the requested changes, let me know if anything else is required. |
|
@gonzomir Thanks for the PR. From what I've researched, the word
As you can see, the word Are there any steps to actually check the problem being proposed this time? |
jorgefilipecosta
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51063.
What?
Use _x() with appropriate context when translating the word 'Header'.
Why?
The word 'Header' appears in different context in both Gutenberg and core, which makes it hard to translate.
How?
Add context to translatable strings when the context requires different translations.
Testing Instructions
Not sure about that, couldn't find information on how Gutenberg translation files are generated.