Fixed quote to heading transformation. #5088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
|
I had a JavaScript error by doing |
jorgefilipecosta
force-pushed
the
fix/quote-heading-transforms
branch
2 times, most recently
from
e8e0763 to
f0d1ca9
Compare
I was able to replicate the problem 👍 , it should be fixed now. |
youknowriad
reviewed
Feb 16, 2018
blocks/library/quote/index.js
Outdated
|
|
||
| return [ text, quote ]; | ||
| const headingContent = castArray( isString( get( value, [ 0, 'children' ] ) ) ? |
There was a problem hiding this comment.
should we extract this value, [ 0, 'children' ] to a variable? it seems used three times here?
youknowriad
approved these changes
Feb 16, 2018
jorgefilipecosta
force-pushed
the
fix/quote-heading-transforms
branch
from
f0d1ca9 to
bbce154
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #5052
This PR corrects the logic of quote to heading transform.
The logic is now the following:
If no citation and no content exist an empty heading is created.
If citation exists but content does not exist a heading is created with citation as the content.
In other citations the first paragraph of the quote is transformed into and heading and new quote is created equal to the original but with the first paragraph removed. If the quote just contains one paragraph the new quote will contain just the citation.
How Has This Been Tested?
Use transformations from quote to heading and verify the logic specified above is working correctly.