Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transforming quote without citation to heading produces an extra empty quote #14313

Closed
csvarga opened this issue Mar 7, 2019 · 0 comments
Closed
Assignees
Labels
[Type] Bug An existing feature does not function as intended

Comments

@csvarga
Copy link

csvarga commented Mar 7, 2019

Bug description:
In the editor when transforming from quote block type to heading block type, and the quote has quote content but no citation, it creates a new empty quote block type that seems unnecessary.

Steps to reproduce the behavior:

  1. Create a quote block type
  2. Write something in the quote content area, and leave citation party empty
  3. Click Change block type
  4. Transform To: click Heading

What we start with:
One quote with quote content and no citation

What we should end up with:
One heading block with the quote content

What we do end up with:
One heading block (with the quote content) and another quote block with no content at all

Tested on:

  • Desktop
  • OS: macOS 10.14.3
  • Browser: Chrome 72.0.3626.96
  • WordPress: version 5.1
  • Gutenberg: version 5.2.0

Other notes:
I found #5052 describing the issue, then #5088 supposedly fixed it, but the logic that has been implemented and is live now still seems strange. It is not clear why the extra quote block should be created, what use case that serves.

@csvarga csvarga changed the title Transforming Quote without citation to Heading produces an extra empty Quote Transforming quote without citation to heading produces an extra empty quote Mar 7, 2019
@jorgefilipecosta jorgefilipecosta self-assigned this Mar 8, 2019
@jorgefilipecosta jorgefilipecosta added the [Type] Bug An existing feature does not function as intended label Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants