Edit Post: Unlock useShouldContextualToolbarShow outside of the component #50612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
|
Size Change: -12 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
glendaviesnz
approved these changes
May 15, 2023
Mamaduka
requested review from
draganescu,
noisysocks,
tellthemachines,
adamziel and
kevin940726
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is similar to #50506 and #50509.
PR moves the private
useShouldContextualToolbarShowhook unlocking outside of the component.Why?
The private hooks can be unlocked at the file level. There's no need to perform the action on each component re-render.
Testing Instructions
Confirm post editor loads without errors.