Navigation: Unlock private APIs outside of the component #50509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
|
Size Change: +1 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7389b834c1c07f1b1aa3cdaf1442186e139681b2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4935878307
|
Mamaduka
force-pushed
the
update/navigation-private-components
branch
from
7389b83 to
e6d7ec9
Compare
talldan
approved these changes
May 11, 2023
This was referenced May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR unlocks the
OffCanvasEditorandLeafMoreMenuprivate components outside the function.Why?
The private components can be unlocked at the file level. There's no need to perform the action on each component re-render.
Testing Instructions
Screenshots or screencast