Template editing: improve revert notices #50302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
[Feature] Full Site Editing
[Feature] Site Editor
glendaviesnz
commented
May 4, 2023
| actions: [ | ||
| { | ||
| label: __( 'Undo' ), | ||
| onClick: undoRevert, | ||
| }, | ||
| ], | ||
| } ); | ||
| } else { |
There was a problem hiding this comment.
this may be needed for some other usage of revert template, but I couldn't see where.
|
Size Change: +81 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
May 4, 2023
| type: 'snackbar', | ||
| id: noticeId, |
There was a problem hiding this comment.
If you use the static ID, removing it above is unnecessary.
I've used a similar method in #45348.
There was a problem hiding this comment.
Yeh, my thinking in this case was that because the unique id prevents the stacking of snackbars, if you revert multiple templates one after the other the user doesn't get a clear indication of the success of each revert, ie. they revert one and the snackbar appears and stays, they revert another and the same snackbar is still just sitting there. But with the remove added a new snackbar appears for each revert to give confirmation, but still only one at a time.
Do you think this makes sense?
|
Fixes #49165. |
ramonjd
approved these changes
May 15, 2023
Thanks @ramonjd, I will add a separate issue for this. |
|
New issue added for the snackbars appearing again when moving between modes #50624 |
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Improves wording on template revert notices, and prevents these notices from stacking.
Why?
Current use of word 'Entity' is confusing, and the stacking of the notices is annoying.
Fixes: #44841
How?
Specifies in notice if it is a template or template part that is being reverted and adds a notice id so only one snackbar appears at a time.
Testing Instructions
Clear customizationsoption from the Actions menuTemplate part revertedorTemplate revertedand that only one snackbar with this message appears at a timeScreenshots or screencast
template-revert.mp4