-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify template part revert process #44841
Comments
Agreed with all of this :) The green "Template reverted" notice can be deleted – we should use Snackbars for confirmation of this action. Speaking of which, navigating away from the current view should probably hide any visible Snackbars, it's a bit strange how they stack and persist currently. Snackbar content should include the entity name: "Index reverted", "Header reverted". |
They also stay for a long time! Most snackbars disappear too quickly, ours stays for maybe a second or two too long, IMO 😅 |
Hey, I'd like to help solve this issue, please tell me where I should start |
Sorry for the late reply @methlox, here's some reading material that should be helpful: https://github.com/WordPress/gutenberg/blob/trunk/docs/contributors/code/README.md |
I spent some time looking into this a couple of weeks ago and found that much of the relevant code is shared between the Templates and Template Parts screens (now "Manage all templates" and "Manage all template parts"). Is it acceptable for the changes proposed here apply to both screens or do template parts need to be treated differently? |
I don't see any need for them to be treated differently during this process. |
Seems like the template part revert process or should I say the message after reverting is clarified more by "Template reverted" BTW, I was looking at it from the trunk branch. 👍🏻 |
Currently, when you revert a template part, a few aspects of the experience make it feel a bit janky/unpredictable:
Here's a video showing the current experience with 6.1 beta 3:
improve.revert.template.part.process.mov
To improve this, I think we need to keep the order of template parts the same and simplify the notices. For example, I know that technically speaking a part of the template was reverted and the notice should be clearer to prevent confusion. cc @WordPress/gutenberg-design
The text was updated successfully, but these errors were encountered: