Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify template part revert process #44841

Closed
annezazu opened this issue Oct 10, 2022 · 7 comments · Fixed by #50302
Closed

Clarify template part revert process #44841

annezazu opened this issue Oct 10, 2022 · 7 comments · Fixed by #50302
Assignees
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") General Interface Parts of the UI which don't fall neatly under other labels. Good First Issue An issue that's suitable for someone looking to contribute for the first time

Comments

@annezazu
Copy link
Contributor

Currently, when you revert a template part, a few aspects of the experience make it feel a bit janky/unpredictable:

  • After reverting, the template part order changes.
  • Upon entering the site editor, you are met with two notices (a bit overwhelming).
  • The top level notice says "template reverted" which feels jarring when you only reverted a template part.
  • The second notice says "entity reverted" in a completely separate part of the experience.

Here's a video showing the current experience with 6.1 beta 3:

improve.revert.template.part.process.mov

To improve this, I think we need to keep the order of template parts the same and simplify the notices. For example, I know that technically speaking a part of the template was reverted and the notice should be clearer to prevent confusion. cc @WordPress/gutenberg-design

@annezazu annezazu added General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback. [Block] Template Part Affects the Template Parts Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Oct 10, 2022
@jameskoster
Copy link
Contributor

Agreed with all of this :)

The green "Template reverted" notice can be deleted – we should use Snackbars for confirmation of this action.

Speaking of which, navigating away from the current view should probably hide any visible Snackbars, it's a bit strange how they stack and persist currently.

Snackbar content should include the entity name: "Index reverted", "Header reverted".

@jameskoster jameskoster added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels Oct 11, 2022
@jasmussen
Copy link
Contributor

it's a bit strange how they stack and persist currently.

They also stay for a long time! Most snackbars disappear too quickly, ours stays for maybe a second or two too long, IMO 😅

@noisysocks noisysocks added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Nov 4, 2022
@methlox
Copy link

methlox commented Dec 22, 2022

Hey, I'd like to help solve this issue, please tell me where I should start

@jameskoster
Copy link
Contributor

Sorry for the late reply @methlox, here's some reading material that should be helpful: https://github.com/WordPress/gutenberg/blob/trunk/docs/contributors/code/README.md

@apmatthews
Copy link
Contributor

I spent some time looking into this a couple of weeks ago and found that much of the relevant code is shared between the Templates and Template Parts screens (now "Manage all templates" and "Manage all template parts"). Is it acceptable for the changes proposed here apply to both screens or do template parts need to be treated differently?

@jameskoster
Copy link
Contributor

I don't see any need for them to be treated differently during this process.

@priyomukul
Copy link

priyomukul commented Feb 17, 2023

Seems like the template part revert process or should I say the message after reverting is clarified more by "Template reverted"

BTW, I was looking at it from the trunk branch.

👍🏻

@annezazu annezazu added this to Polish Apr 28, 2023
@priethor priethor moved this to 💻 Needs development in Polish Apr 28, 2023
@glendaviesnz glendaviesnz self-assigned this May 4, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 4, 2023
@priethor priethor moved this from Needs development to In progress in Polish May 8, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 17, 2023
@priethor priethor moved this from In progress to Done in Polish May 17, 2023
@priethor priethor removed the Needs Dev Ready for, and needs developer efforts label May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") General Interface Parts of the UI which don't fall neatly under other labels. Good First Issue An issue that's suitable for someone looking to contribute for the first time
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

9 participants