Group Block: Allow blocks to be dragged onto it in its placeholder state #49361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Bug
andrewserong
requested review from
noisysocks,
jasmussen,
apeatling,
richtabor and
tellthemachines
|
Size Change: +11 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Mar 27, 2023
apeatling
approved these changes
Mar 27, 2023
richtabor
deleted the
update/group-block-allow-dragging-blocks-in-placeholder-state
branch
|
Thanks for the speedy reviews and for merging this in! 🙇 |
|
Oh, just realised I accidentally removed the |
25 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #49256
Allow dragging blocks into the Group block within its placeholder state.
Why?
As raised in #49256 (comment), prior to this PR, it isn't possible to drag blocks into the Group block within its placeholder state. It turns out this is because in the placeholder state the children of
useInnerBlocksPropsare not rendered (InnerBlocks), which means that theblockListSettingslist is not updated to include the Group block, so it isn't considered as being allowed to receive child blocks.How?
Viewwith theinnerBlocksPropsapplied there, and{ innerBlocksProps.children }is explicitly output (introduced in Paste: reuse file transforms for file pasting #45891).renderAppendervalue passed touseInnerBlocksPropsis updated so that it's explicitly set tofalsewhen in the placeholder state. I've added some comments to explain each value, since it wasn't obvious to me at first what the difference betweenfalseandundefinedwould be.Testing Instructions
Screenshots or screencast