-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List View: Tweaks to improve usability, visual feedback, and keyboard behaviour #49563
Comments
I wasn't able to get it working for expanded parents (otherwise I'd open a PR), but I think this would be a win. It makes List View feel much less fragile imo. drag.mp4 |
Agreed, thanks for showing the quick demo! I'm happy to have a go at it once a couple of my WIP PRs have advanced a little further 👍 |
I think so too. The only bit I'd consider adapting is the grayed-out not maintain the accent color. |
Update: I'm just refreshing this issue now that WP 6.3 is out, and to highlight some of the issues that could be good to tackle for WP 6.4. With the issue description now updated, for posterity, below is a list of some of things that made it into 6.3: A non-exhaustive list of things that made it in for 6.3Improving drag-and-drop and related visual issues
Improving interactions using the keyboard
Resolved tasksThe above features were implemented across the below PRs:
What's next?I have updated the issue description with tasks that I think would be good to work on next. It's likely that not all of these will make it in for 6.4, but IMO they're all good tasks to look into. First off, image thumbnails have been added to the list view in #53381, and next up I'm planning to look into a couple of tricky bugs related to the windowing logic (#41613 and #42031) Note: this issue is intentionally non-exhaustive, and there are plenty of other tasks with the List View label not covered here. If there are any major ones that folks think belong in this list, though, feel free to drop a link here! |
@andrewserong if possible, mind updating this issue with 6.5 in mind? It would help pull together PRs and organize efforts for the 6.5 board for the release squad ❤️ |
Thanks for the ping @annezazu! I've updated the issue description with a section for prioritised tasks for 6.5 and a list of tasks that have already been completed. Most tasks for 6.5 have been completed, in particular adding right-click support and making it clearer that blocks can be dragged. The two outstanding tasks for 6.5 are ones that I have WIP PRs for. There's dragging over a collapsed block to expand it (WIP PR in #56579). That one's fairly straightforward to implement. The stretch goal is to improve the experience of dragging within the list view by displacing list items as we drag up and down the list. This one's more complex to implement as it changes quite a few things. I have a WIP PR for that over in #56625, and I'm hoping to get it viable for 6.5 if we don't run into any further blockers with it 🤞 IMO, the other issues here are not urgent for 6.5. |
Hi @andrewserong, Lot's of great work here ❤️ Would you please drop an update on where you see progress for this in the WordPress 6.5 release cycle? The Editor Triage team and Editor Leads will likely need to assess whether this should continue to reside on the WordPress 6.5 Editor Tasks board, and a summary would help. Thanks! |
Thanks for the ping @colorful-tones! The prioritised tasks that could make it in time for 6.5 have all been completed, so I've moved this tracking issue over to the Done column. There were quite a few PRs that made it in for this release (all linked at the top of this issue description). From my perspective the main highlights that folks might be interested in include:
That's pretty much it for 6.5 features, the remaining PRs were mostly small bug fixes and polish such as auto-expanding collapsed blocks in the list view when dragging in the editor canvas — those sorts of fixes can be a bit invisible since once they're in, you sort of expect that it was always that way 😄 I'll leave the tracking issue description as it is for now, so that it's clear which PRs made it in for 6.5. My intention is to continue working on this for 6.6, by which time we should be able to finalise a WYSIWYG drag chip and close out this tracking issue 🤞 |
When you start work on this @andrewserong can we try the following? Creating an issue with the Epic tag that's specifically scoped for WordPress 6.6 and references this as the main tracking issue of overall tasks. This will help communicate more clearly what's being worked on for 6.6 and keep this tracking issue from getting too long/hard to keep track of. |
That's a great idea @annezazu! If I don't get to it today, I'll open an Epic issue for the proposed 6.6 tasks next week, and tidy up the issue description for this one 👍 |
Update: I've edited this issue's description to remove items that landed in WP 6.5. For prioritised tasks for WP 6.6 (ones that I know either myself or someone else is planning to work on), I've opened up #60099 as an "epic" issue. Since that issue is the one for tracking tasks for WordPress 6.6, I've added that one to the 6.6 Editor Tasks project board, and removed this issue from it. If it helps folks to have this issue be on that board, too, do feel free to add it back on 🙂 To recap: this issue is still a great place to flag nice-to-haves or bigger picture issues for List View usability. I'll be using #60099 for tracking the granular tasks for WP 6.6 that I work on. |
@diggeddy thanks for reporting, unfortunately I haven't been able to replicate this. I've tested in FF and Chrome on a Mac, with both WP 6.5 without Gutenberg activated, and with Gutenberg Can you please confirm which OS you're running, which WP version, whether Gutenberg is activated, and a little more about your testing environment? Feel free to open an issue and ping me on it if it's easier. I'd like to be able to try to replicate the issue so I can better understand where to investigate next 🙂 |
@andrewserong awesome glad to hear that, and apologies i had not seen the previous ping. |
The list view frequently comes up as a feature that folks both love, and also find frustrating or challenging to use. There are already a number of issues that address aspects of the list view's usability. The purpose of this issue is to track some of these issues, and provide a list of related issues that, grouped together, should hopefully help improve the overall usability of the list view.
For prioritised tasks for WordPress 6.6, see #60099
Exhaustive list
Outstanding bugs to address
Improving drag-and-drop and related visual issues
Improving interactions using the keyboard
Visual issues and tasks
Misc tasks related to usability
The text was updated successfully, but these errors were encountered: