Query Loop: Constraint list item(li) styles to the direct children of the main list
#49303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of the main list
ntsekouras
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.34 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Mar 23, 2023
|
Flaky tests detected in 2736190. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4499769787
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In Query Loop if we have selected the
grid view, the styles for the list items of Query Loop were leaking to to any (ul) content. This goes for blocks too like theSocial Iconsblock that renders a list..This seems to have slipped through the cracks for maybe more than a couple of years 😱 .
Screen.Recording.2023-03-23.at.12.35.51.PM.mov
Testing Instructions
Social Iconsblocks and add at least one itemgrid/listview in Query Loop's block toolbar