Query Loop: Show Featured Image placeholders in all posts #49301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
|
Size Change: +4 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Mar 23, 2023
There was a problem hiding this comment.
The fix works as expected!
An alternative would be to show all placeholders that are currently hidden in these previews(useBlockPreview).
We can only hide placeholders without illustrations - .components-placeholder:not(.has-illustration).
But I like the idea of progressive fixes for placeholders. Not every block needs to display a placeholder state in previews.
|
Nice one. Confirmed this also still correctly works with borders and radiuses:
|
|
Flaky tests detected in 8789e6b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4499554990
|
ntsekouras
deleted the
fix/show-post-featured-image-placeholder-in-query
branch
|
Thanks for fixing this up @ntsekouras!
This is a really interesting case, I think it reveals that we sort of have two different categories of placeholders when it comes to block previews.
From a bit of digging, I think the issue here might have been introduced back in #41605 where the placeholder illustrations were moved from being output directly, to forming part of the
I agree with @Mamaduka here, I think it makes sense for blocks to explicitly determine when they should display placeholders in previews. But, we can always revisit that assumption if we wind up having to fix up more blocks 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #49167
How?
I actually just added the style change for this block. An alternative would be to show all placeholders that are currently hidden in these previews(
useBlockPreview). @andrewserong might have some context why he introduced this style.Testing Instructions