Placeholder: Add an illustration option to the Placeholder component #41605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -575 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
Jun 9, 2022
There was a problem hiding this comment.
This is great and it works great! Thanks for finding this place for the illustration, didn't occur to me, I thought I'd have to export yet another thing, but it was right there.
I think the addition could improve other blocks as well, to show the under construction state, check out image and table with illustration set to true:
mburridge
added
the
Needs Dev Note
|
Added the Needs Dev Note label in case this needs a dev note (either individual or as part of a "misc" dev note) for WP 6.1 release. |
|
It should need a misc note about |
This was referenced Oct 7, 2022
|
@draganescu would you please add a comment for the Misc Dev note here, please? |
|
In WordPress 6.1 the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I noticed that we have the same SVG in three places to add an illustration to the Placeholder component. This moves that SVG into a the Placeholder component itself so that we can share the code and simplify the implementation.
Why?
Make it simpler!
How?
This adds a new prop
withIllustrationto the placeholder component, which is used to determine whether to output the illustration. It then removes the illustration from the individual components as well as the associated CSS.Testing Instructions
Screenshots or screencast
Note
The illustration used in the Site Logo block is slightly different to the others, but IMO its better to have consistency.