Lodash: Refactor post editor away from _.map()
#47193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
Mamaduka,
sgomes,
aristath,
jsnajdr,
swissspidy,
flootr,
chad1008,
ntsekouras,
fabiankaegy and
brookewp
tyxla
added
the
Mobile App - i.e. Android or iOS
tyxla
commented
Jan 16, 2023
| @@ -50,7 +45,7 @@ function BlockManagerCategory( { title, blockTypes } ) { | |||
| }, [] ); | |||
| const toggleAllVisible = useCallback( | |||
| ( nextIsChecked ) => { | |||
| const blockNames = map( blockTypes, 'name' ); | |||
| const blockNames = blockTypes.map( ( { name } ) => name ); | |||
There was a problem hiding this comment.
Always an array (here and in the next usage a few lines below):
| const checkedBlockNames = map( filteredBlockTypes, 'name' ).filter( | ||
| ( type ) => ! hiddenBlockTypes.includes( type ) | ||
| ); | ||
| const checkedBlockNames = filteredBlockTypes |
There was a problem hiding this comment.
Already an array since it's passing through .filter() already.
| @@ -50,7 +45,7 @@ export default function MetaBoxes( { location } ) { | |||
|
|
|||
| return ( | |||
| <> | |||
| { map( metaBoxes, ( { id } ) => ( | |||
| { ( metaBoxes ?? [] ).map( ( { id } ) => ( | |||
There was a problem hiding this comment.
| @@ -36,7 +31,7 @@ export function MetaBoxesSection( { | |||
| { areCustomFieldsRegistered && ( | |||
| <EnableCustomFieldsOption label={ __( 'Custom fields' ) } /> | |||
| ) } | |||
| { map( thirdPartyMetaBoxes, ( { id, title } ) => ( | |||
| { thirdPartyMetaBoxes.map( ( { id, title } ) => ( | |||
There was a problem hiding this comment.
Already used as an array above in this component.
| @@ -136,7 +131,7 @@ function Editor( { | |||
| // all block types). | |||
| const defaultAllowedBlockTypes = | |||
| true === settings.allowedBlockTypes | |||
| ? map( blockTypes, 'name' ) | |||
| ? blockTypes.map( ( { name } ) => name ) | |||
There was a problem hiding this comment.
Will always be an array:
| @@ -74,7 +73,7 @@ class Editor extends Component { | |||
| // all block types). | |||
| const defaultAllowedBlockTypes = | |||
| true === settings.allowedBlockTypes | |||
| ? map( blockTypes, 'name' ) | |||
| ? blockTypes.map( ( { name } ) => name ) | |||
There was a problem hiding this comment.
Always an array:
tyxla
force-pushed
the
refactor/lodash-map-edit-post
branch
from
1cbecb4 to
f707800
Compare
|
Size Change: -3 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Lodash's
_.map()from the post editor package. There are just a couple of usages and conversion is pretty straightforward.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're using
Array.prototype.map()instead. We're also adding nullish coalescing where necessary.Testing Instructions