Lodash: Refactor post editor away from _.map()

WordPress · Jan 16, 2023 · f707800 · f707800
1 parent 4e29eee
commit f707800
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 29 deletions.
diff --git a/packages/edit-post/src/components/block-manager/category.js b/packages/edit-post/src/components/block-manager/category.js
@@ -1,8 +1,3 @@
-/**
- * External dependencies
- */
-import { map } from 'lodash';
-
 /**
  * WordPress dependencies
  */
@@ -50,7 +45,7 @@ function BlockManagerCategory( { title, blockTypes } ) {
 	}, [] );
 	const toggleAllVisible = useCallback(
 		( nextIsChecked ) => {
-			const blockNames = map( blockTypes, 'name' );
+			const blockNames = blockTypes.map( ( { name } ) => name );
 			if ( nextIsChecked ) {
 				showBlockTypes( blockNames );
 			} else {
@@ -64,9 +59,9 @@ function BlockManagerCategory( { title, blockTypes } ) {
 		return null;
 	}
 
-	const checkedBlockNames = map( filteredBlockTypes, 'name' ).filter(
-		( type ) => ! hiddenBlockTypes.includes( type )
-	);
+	const checkedBlockNames = filteredBlockTypes
+		.map( ( { name } ) => name )
+		.filter( ( type ) => ! hiddenBlockTypes.includes( type ) );
 
 	const titleId = 'edit-post-block-manager__category-title-' + instanceId;
 

diff --git a/packages/edit-post/src/components/meta-boxes/index.js b/packages/edit-post/src/components/meta-boxes/index.js
@@ -1,8 +1,3 @@
-/**
- * External dependencies
- */
-import { map } from 'lodash';
-
 /**
  * WordPress dependencies
  */
@@ -50,7 +45,7 @@ export default function MetaBoxes( { location } ) {
 
 	return (
 		<>
-			{ map( metaBoxes, ( { id } ) => (
+			{ ( metaBoxes ?? [] ).map( ( { id } ) => (
 				<MetaBoxVisibility key={ id } id={ id } />
 			) ) }
 			<MetaBoxesArea location={ location } />

diff --git a/packages/edit-post/src/components/preferences-modal/meta-boxes-section.js b/packages/edit-post/src/components/preferences-modal/meta-boxes-section.js
@@ -1,8 +1,3 @@
-/**
- * External dependencies
- */
-import { map } from 'lodash';
-
 /**
  * WordPress dependencies
  */
@@ -36,7 +31,7 @@ export function MetaBoxesSection( {
 			{ areCustomFieldsRegistered && (
 				<EnableCustomFieldsOption label={ __( 'Custom fields' ) } />
 			) }
-			{ map( thirdPartyMetaBoxes, ( { id, title } ) => (
+			{ thirdPartyMetaBoxes.map( ( { id, title } ) => (
 				<EnablePanelOption
 					key={ id }
 					label={ title }

diff --git a/packages/edit-post/src/editor.js b/packages/edit-post/src/editor.js
@@ -1,8 +1,3 @@
-/**
- * External dependencies
- */
-import { map } from 'lodash';
-
 /**
  * WordPress dependencies
  */
@@ -136,7 +131,7 @@ function Editor( {
 			// all block types).
 			const defaultAllowedBlockTypes =
 				true === settings.allowedBlockTypes
-					? map( blockTypes, 'name' )
+					? blockTypes.map( ( { name } ) => name )
 					: settings.allowedBlockTypes || [];
 
 			result.allowedBlockTypes = defaultAllowedBlockTypes.filter(

diff --git a/packages/edit-post/src/editor.native.js b/packages/edit-post/src/editor.native.js
@@ -2,7 +2,6 @@
  * External dependencies
  */
 import memize from 'memize';
-import { map } from 'lodash';
 import { I18nManager } from 'react-native';
 import { GestureHandlerRootView } from 'react-native-gesture-handler';
 
@@ -74,7 +73,7 @@ class Editor extends Component {
 			// all block types).
 			const defaultAllowedBlockTypes =
 				true === settings.allowedBlockTypes
-					? map( blockTypes, 'name' )
+					? blockTypes.map( ( { name } ) => name )
 					: settings.allowedBlockTypes || [];
 
 			settings.allowedBlockTypes = defaultAllowedBlockTypes.filter(