Revert "Navigation List View: Remove empty cell when there is no edit button" #47061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 78deee0.
|
Size Change: -13 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in d33b72f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3892747786
|
MaggieCabrera
approved these changes
Jan 12, 2023
There was a problem hiding this comment.
LGTM, this doesn't really show on our case because showBlockActions is false. In any case we still need a follow up to remove the accesibility issue from the original list view implementation in order to fix #47025
juanmaguitar
added
[Type] Regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #46439
This causes an accessibility regression: Nav offcanvas - retain key block options but make disabled with appropriate description #47025