Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav offcanvas - retain key block options but make disabled with appropriate description #47025

Closed
getdave opened this issue Jan 10, 2023 · 4 comments
Labels
[Block] Navigation Affects the Navigation Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Accessibility Feedback Need input from accessibility [Type] Bug An existing feature does not function as intended

Comments

@getdave
Copy link
Contributor

getdave commented Jan 10, 2023

As reported in #46939 (comment) by @talldan:

there are some missing options for some blocks (Page List children don't have an "Edit block" button), screen reader users may wonder why this is.

It also makes the grid style keyboard navigation confusing, if I press the up arrow from from the block settings of the first page list item, I land on the edit button for the parent page list block, which means I didn't traverse the structure as a grid.

I think it'd be better to show an aria-disabled version of the "edit block" button with an appropriate description. Possibly also consider this for other relevant options.

@scruffian
Copy link
Contributor

This is partly caused by this PR: #47061, which we will revert.

There are also issues within the List View component which make this more complex. We don't output the additional cells when showBlockActions is false. We should review this in the List View and ensure that those cells are always output for the benefit of keyboard users.

@MaggieCabrera
Copy link
Contributor

I've been playing with this and I'm not sure having the empty cells with a hidden text would be beneficial. This is what I've found so far:

The list view makes use of colspan to expand when some of the columns are not present, namely the "actions" column and the "movers". The movers are apparently not being used by the blocks, and I'm lacking context here for if that will be active or not. The actions are what we call the 3 dot menu, which is not present on blocks that are hiding the toolbar.

The nav block on the sidebar inspector adds an extra edit button for some of the blocks, but not all.

Do we know of a case like this, where we display a message for keyboard users when an action is not present? I'm hesitant to implement such a thing only for the case of the edit button. I was trying to find what the consensus is around using colspan in terms of a11y and it seems like the general rule is to use it sparingly. This case's not too obvious to me. Adding the empty table cells in all of these is going to break the styles quite a bit too.

@getdave
Copy link
Contributor Author

getdave commented Jan 31, 2023

This will become irrelevant if #47608 lands which removes the dedicated edit button.

@getdave
Copy link
Contributor Author

getdave commented Feb 2, 2023

With #47608 there is no "edit" button so this is no longer relevant.

@getdave getdave closed this as completed Feb 2, 2023
@priethor priethor added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). and removed [a11y] Labelling labels Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Accessibility Feedback Need input from accessibility [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants