-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nav offcanvas - retain key block options but make disabled with appropriate description #47025
Comments
This is partly caused by this PR: #47061, which we will revert. There are also issues within the List View component which make this more complex. We don't output the additional cells when |
I've been playing with this and I'm not sure having the empty cells with a hidden text would be beneficial. This is what I've found so far: The list view makes use of colspan to expand when some of the columns are not present, namely the "actions" column and the "movers". The movers are apparently not being used by the blocks, and I'm lacking context here for if that will be active or not. The actions are what we call the 3 dot menu, which is not present on blocks that are hiding the toolbar. The nav block on the sidebar inspector adds an extra edit button for some of the blocks, but not all. Do we know of a case like this, where we display a message for keyboard users when an action is not present? I'm hesitant to implement such a thing only for the case of the edit button. I was trying to find what the consensus is around using colspan in terms of a11y and it seems like the general rule is to use it sparingly. This case's not too obvious to me. Adding the empty table cells in all of these is going to break the styles quite a bit too. |
This will become irrelevant if #47608 lands which removes the dedicated edit button. |
With #47608 there is no "edit" button so this is no longer relevant. |
As reported in #46939 (comment) by @talldan:
The text was updated successfully, but these errors were encountered: