Navigation Link Popover: use placement prop instead of legacy position prop #44394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67 tasks
|
Size Change: +13 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
17 tasks
ciampo
force-pushed
the
refactor/navigation-link-popover-placement-position
branch
from
8e05619 to
64a8741
Compare
ciampo
added
[Type] Code Quality
ciampo
deleted the
refactor/navigation-link-popover-placement-position
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #44401
Use the new
placementprop instead of the legacypositionprop to define thePopover's placement when opened.Why?
With the recent refactor of the
Popovercomponent tofloating-ui, we're in the process of refactoring all of its usages to the newplacementprop (native tofloating-ui). See #44401 for more detailsHow?
Swap
positionwith the new correspondingplacement.See this conversion table that we're currently using to map
positionvalues toplacementvalues.Testing Instructions
Screenshots or screencast
Kapture.2022-10-28.at.18.00.48.mp4