-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Popover: refactor all usages of the legacy position
prop to the placement
prop
#44401
Open
13 of 17 tasks
Tracked by
#42770
Labels
[Package] Components
/packages/components
[Type] Overview
Comprehensive, high level view of an area of focus often with multiple tracking issues
Comments
67 tasks
ciampo
changed the title
Refactor all consumers to use the new prop
Popover: refactor all usages of the legacy Sep 22, 2022
position
prop to the placement
prop
This was referenced Oct 21, 2022
Merged
This was referenced Jan 3, 2023
jordesign
added
the
[Type] Overview
Comprehensive, high level view of an area of focus often with multiple tracking issues
label
Aug 3, 2023
29 tasks
It looks like the majority of work planned here has been completed. Closing this out as a result but happy to reopen if that's incorrect! |
@annezazu I think the issue could still be relevant, I'd love to get to complete the missing tasks if possible. Let's keep it open for now, and see if we can get to (at least) some of those |
github-project-automation
bot
moved this to In progress (owned) ⏳
in WordPress Components
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Package] Components
/packages/components
[Type] Overview
Comprehensive, high level view of an area of focus often with multiple tracking issues
After #40740, there are two different props in the
Popover
component to affect is position:position
(legacy) andplacement
(new)In order to deprecate the legacy
position
prop from thePopover
component, we should first migrate all current usages to the newplacement
prop:position
fromPopover
's storybookposition
in favour ofpopoverProps.placement
,Dropdown
: theposition
prop is made redundant bypopoverProps
#46858)Dropdown
: deprecateposition
prop, usepopoverProps
instead #46865position
in favour ofplacement
too) Tooltip: addplacement
prop to replace deprecatedposition
#54264position={
orposition:
props:tooltipPosition
prop (ie.Button
component)The text was updated successfully, but these errors were encountered: