Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown: the position prop is made redundant by popoverProps #46858

Closed
ciampo opened this issue Jan 3, 2023 · 0 comments · Fixed by #46865
Closed

Dropdown: the position prop is made redundant by popoverProps #46858

ciampo opened this issue Jan 3, 2023 · 0 comments · Fixed by #46865
Assignees
Labels
[Package] Components /packages/components [Type] Enhancement A suggestion for improvement.

Comments

@ciampo
Copy link
Contributor

ciampo commented Jan 3, 2023

What

While taking a look at the recent work done in #45787, I realized that the position of the popover for the Dropdown can be set in two different ways:

This situation is not ideal, since the component offers two separate ways to set the popover's position which can create confusion in the user:

  • setting it via popoverProps overrides the value set via the position prop
  • even more confusing, passing popoverProps.placement (which is the suggested prop instead of position) doesn't have any effects, since position is always set from the position prop and it will override the placement

Proposed solution

I suggest we deprecate the position prop altogether, and we discourage its usage. We should use popoverProps.placement instead to set the popover's position.

@ciampo ciampo self-assigned this Jan 3, 2023
@ciampo ciampo added the [Package] Components /packages/components label Jan 3, 2023
@kathrynwp kathrynwp added the [Type] Enhancement A suggestion for improvement. label Jan 3, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 3, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants