Navigation: Remove unneeded gap:inherit rule on wrapper element of navigation block #43669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p is provided by layout support
andrewserong
added
[Type] Bug
|
Size Change: -14 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Aug 29, 2022
There was a problem hiding this comment.
Thanks for working on this, let's try it. As it turns out, the PR is the same as I tried in #43422, which eventually I closed as it seemed like a Global Styles preset as suggested in the comments there might be a better approach. That might still be the case, but per your debugging around specificity changes, this seems like the approach.
Before, empty theme and TT17, editor and frontend:
After, TT17 and empty theme, editor and frontend:
I'd love a sanity check from another! But otherwise land it, thank you for the PR!
Thanks for reviewing @jasmussen! Apologies, I was working too quickly and didn't take a look at your previous effort there. I think this fix is probably a good short-term approach so that we're mostly focusing on resolving the current bug — flex layouts get a default value of Semi-related, the Columns block has a default / fallback value of
Good thinking. I wonder if @scruffian or others might be able to give us a confidence check here? |
|
Oh no need to be sorry, I appreciate you taking the energy to shepard this one all the way through! 🙏 |
|
I'm feeling pretty confident about the approach here and am back from travelling, so will merge this one in. Happy to follow-up if it winds up causing any issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #42955
Remove the
gap: inheritrule for the root Navigation block classname selector.Why?
The Layout block support provides default gap rules for blocks that opt-in to Layout support. For classic themes, in order to ensure that the Layout support does not erroneously override theme styles, the specificity of the default / fallback gap styles are intentionally lower (as introduced in #42665).
However, it appears that the Navigation block currently sets
gap: inheritwhich overrides this rule. As far as I can tell, thewp-block-navigationrule here is a hold-over from back when the block needed to provide its own explicit styles. The inherit rule should only apply to children (or child elements) of the navigation block, and not the root / wrapper element.How?
.wp-block-navigationfrom the list of classnames where the Navigation block applies thegap: inheritruleTesting Instructions
gap: inheritruleScreenshots or screencast