Try: Gap tweaks to navigation #43422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Bug
|
Size Change: -13 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
jasmussen
force-pushed
the
try/navigation-default-gap
branch
from
c3d6821 to
d4a17d0
Compare
|
Should we consider adding a default block spacing value to the navigation block instead? 🤔
|
|
Yes, that does make sense. However I couldn't quite get that to work: that would go in Nevertheless, it looks like the approach I took in this PR works for classic themes, but not block themes 🙈 so it does need a different approach. I'll comment on the original issue. Thanks for the reviews, folks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Hopefully fixes #42955.
A default gap is not provided for navigation in classic themes:
This PR fixes that by removing an inheritance rule that appears to be unnecessary:
Testing Instructions
Please test as many variations of navigation as you can!