Placeholders: Make dashed style a mixin, and apply across. #43512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Enhancement
|
Size Change: -52 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
jasmussen
force-pushed
the
try/dashed-line-color-fix
branch
from
df8e925 to
7fd758c
Compare
jameskoster
reviewed
Aug 25, 2022
| flex: 1 0 $grid-unit-60; | ||
| pointer-events: none; | ||
| min-height: $grid-unit-60 - $border-width - $border-width; | ||
|
|
||
| // Dashed placeholder style. |
There was a problem hiding this comment.
It's a real nitpick, but do we really need the comment? If it's a general codestyle thing then fine, but otherwise it's kind of duplicative considering it includes the exact same words as the mixin name :D
There was a problem hiding this comment.
Nitpicks like these are my favorite 👌
jameskoster
reviewed
Aug 25, 2022
packages/base-styles/_mixins.scss
Outdated
| @@ -202,6 +202,11 @@ | |||
| } | |||
| } | |||
|
|
|||
| @mixin dashed-placeholder-style() { | |||
There was a problem hiding this comment.
Might we consider placeholder-style as the name instead, just incase we decide to change the border style in the future? 🤔
jasmussen
force-pushed
the
try/dashed-line-color-fix
branch
from
7fd758c to
fcb3153
Compare
|
Thank you for the review! Rebased, renamed mixin, removed comments. Still looks good, here's an image and 2 columns: |
|
Hi, @jasmussen I think this enhancement got regressed after #44190. The dashed border style is missing on the current trunk. |
|
Visually it was intentional to move forward with the borderless version in 44190 to reduce noise as the placeholders become increasingly useful in patterns. That new style is still in need of some iteration, see #44460, and as it stands, 6.1 should ship with the bordered version. Or is there a different aspect to the regression I was missing? |
|
Sorry, I wasn't clear. The #44190 also removed borders for Group/Columns appender placeholders. So now, unselected empty Group or Columns isn't visible on the canvas. Screenshot
|
|
Oh that's no good! I'll take a look, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
As placeholders in the dashed-outline style have received polish in the last week, an opacity differential has stood out:
This PR makes the styles the same across, and extracts the particular dash-style into a mixin so it has a better chance to stay in sync across changes:
Testing Instructions
Test placeholders with the new dashed style, Image, Featured Image, Site Logo, and Columns. Dashed styles should look the same.
I noticed a regression with Group, separate from this PR, which I'll follow up on.