Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contextualise placeholders #44460

Open
jameskoster opened this issue Sep 26, 2022 · 4 comments
Open

Contextualise placeholders #44460

jameskoster opened this issue Sep 26, 2022 · 4 comments
Labels
Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

jameskoster commented Sep 26, 2022

A follow-up to the new placeholder styles (#44190).

Let's figure out a way to make it clearer when a placeholder is for an image, or a video, or audio, etc.

Here are some ideas that came up in the original PR:

Use block icons

Use the block name as a label

Use something more literal, while still clearly being a placeholder

cc @WordPress/gutenberg-design

@github-actions
Copy link

Help us move this issue forward. This issue is being marked stale since it has no activity after 15 days of requesting more information. Please add info requested so we can help move the issue forward. Note: The triage policy is to close stale issues that need more info and no response after 2 weeks.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Oct 12, 2022
@jasmussen
Copy link
Contributor

Nice. I like the explorations, but I also like the minimalism of icons, and the fact that they can be entirely generic.

@jasmussen jasmussen removed the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Oct 12, 2022
@richtabor
Copy link
Member

I like the block icons as well. Simple/relative and the icons are already there.

@akasunil
Copy link
Member

I believe that simply using icons will not suffice; users cannot be expected to understand what each icon represents.

Re icons, I'm not a big fan for two reasons:

  1. By principle I think icons should be reserved only for editor UI – toolbars, panels, menus, etc. These placeholders sit somewhere between editor UI and on canvas WYSIWYG which makes the icons feel out of place.

  2. Quite a few aren't all that useful in this context – Featured Image and Site Logo for example... those icons do not clearly communicate the block purpose alone.

I agree with @jameskoster here. However, simply having a name does not guarantee good look and feel. Therefore, I believe we should include both the block icon and the block name. Something like this,

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants