Add optional capture group to url regex in wp-env

[titusdmoore]

What?

Resolve issue where urls with query parameters won't work in wp-env using wp-env.json to include plugins or themes.

Why?

This can cause issues where adding plugins from third party developers can cause issues if they don't have their plugin added to the WordPress marketplace. My experience has been with Gravity Forms. Solves issue #43199

How?

Change the regex string that validates urls to include an optional capture group post .zip that will pass if the string has query parameters.

Testing Instructions

1. Create wp-env.json file with plugins attribute with url values that match old pattern [url]/zip-name.zip and new pattern [url]/zip-name.zip?authAttr={attrValue}
2. Run wp-env start
3. Ensure that both plugin urls have been included into project and have been activated

Screenshots or screencast

[github-actions]

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @titusdmoore! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

[noahtallen]

Overall, this looks good to me. Could you update the tests here?

gutenberg/packages/env/lib/config/test/config.js

Lines 522 to 581 in 6dcf85a

	it( 'should parse zip sources', async () => {
	readFile.mockImplementation( () =>
	Promise.resolve(
	JSON.stringify( {
	plugins: [
	'https://www.example.com/test/path/to/gutenberg.zip',
	'https://www.example.com/test/path/to/gutenberg.8.1.0.zip',
	'https://www.example.com/test/path/to/twentytwenty.zip',
	'https://www.example.com/test/path/to/twentytwenty.1.3.zip',
	'https://example.com/twentytwenty.1.3.zip',
	],
	} )
	)
	);
	const config = await readConfig( '.wp-env.json' );
	const matchObj = {
	pluginSources: [
	{
	type: 'zip',
	url: 'https://www.example.com/test/path/to/gutenberg.zip',
	path: expect.stringMatching( /^(\/|\\).*gutenberg$/ ),
	basename: 'gutenberg',
	},
	{
	type: 'zip',
	url: 'https://www.example.com/test/path/to/gutenberg.8.1.0.zip',
	path: expect.stringMatching(
	/^(\/|\\).*gutenberg.8.1.0$/
	),
	basename: 'gutenberg.8.1.0',
	},
	{
	type: 'zip',
	url: 'https://www.example.com/test/path/to/twentytwenty.zip',
	path: expect.stringMatching(
	/^(\/|\\).*twentytwenty$/
	),
	basename: 'twentytwenty',
	},
	{
	type: 'zip',
	url: 'https://www.example.com/test/path/to/twentytwenty.1.3.zip',
	path: expect.stringMatching(
	/^(\/|\\).*twentytwenty.1.3$/
	),
	basename: 'twentytwenty.1.3',
	},
	{
	type: 'zip',
	url: 'https://example.com/twentytwenty.1.3.zip',
	path: expect.stringMatching(
	/^(\/|\\).*twentytwenty.1.3$/
	),
	basename: 'twentytwenty.1.3',
	},
	],
	};
	expect( config.env.development ).toMatchObject( matchObj );
	expect( config.env.tests ).toMatchObject( matchObj );
	} );

I would just add another entry to that array which includes some query params, and then include that entry in the matchObj

[noahtallen]

Looks good to me, thank you!

[github-actions]

Congratulations on your first merged pull request, @titusdmoore! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!