wp-env: Allow .zip source URLs with query parameters (#43200)

Add optional capture group to url regex in wp-env's .zip source logic to download .zip's from URLs with query parameters. Co-authored-by: Titus Moore <[email protected]>
WordPress · Aug 16, 2022 · d0220ea · d0220ea
1 parent 0b0f9e2
commit d0220ea
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/packages/env/lib/config/parse-config.js b/packages/env/lib/config/parse-config.js
@@ -111,7 +111,7 @@ function parseSourceString( sourceString, { workDirectoryPath } ) {
 	}
 
 	const zipFields = sourceString.match(
-		/^https?:\/\/([^\s$.?#].[^\s]*)\.zip$/
+		/^https?:\/\/([^\s$.?#].[^\s]*)\.zip(\?.+)?$/
 	);
 
 	if ( zipFields ) {

diff --git a/packages/env/lib/config/test/config.js b/packages/env/lib/config/test/config.js
@@ -526,6 +526,7 @@ describe( 'readConfig', () => {
 						plugins: [
 							'https://www.example.com/test/path/to/gutenberg.zip',
 							'https://www.example.com/test/path/to/gutenberg.8.1.0.zip',
+							'https://www.example.com/test/path/to/gutenberg.8.1.0.zip?auth=thisIsAString&token=secondString',
 							'https://www.example.com/test/path/to/twentytwenty.zip',
 							'https://www.example.com/test/path/to/twentytwenty.1.3.zip',
 							'https://example.com/twentytwenty.1.3.zip',
@@ -550,6 +551,14 @@ describe( 'readConfig', () => {
 						),
 						basename: 'gutenberg.8.1.0',
 					},
+					{
+						type: 'zip',
+						url: 'https://www.example.com/test/path/to/gutenberg.8.1.0.zip?auth=thisIsAString&token=secondString',
+						path: expect.stringMatching(
+							/^(\/|\\).*gutenberg.8.1.0$/
+						),
+						basename: 'gutenberg.8.1.0',
+					},
 					{
 						type: 'zip',
 						url: 'https://www.example.com/test/path/to/twentytwenty.zip',