Site Editor: Fix error in compileStyleValue #43116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
tyxla
approved these changes
Aug 10, 2022
packages/edit-site/src/components/global-styles/use-global-styles-output.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Marin Atanasov <[email protected]>
|
Size Change: +801 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
|
Thanks for the quick review, @tyxla. Shorter alternative works for me 👍 |
|
Hi, @oandregal. It might be a good idea to cherry-pick this for 13.9. |
Mamaduka
added
the
Backport to Gutenberg Minor Release
priethor
pushed a commit
that referenced
this pull request
Aug 12, 2022
* Site Editor: Fix error in compileStyleValue * Use shorter alternative Co-authored-by: Marin Atanasov <[email protected]>
priethor
removed
the
Backport to Gutenberg Minor Release
|
Cherry-picked to the 13.9 branch and released in Gutenberg 13.9-rc2 ✅ |
ramonjd
added a commit
that referenced
this pull request
Aug 14, 2024
Use style engine getCSSVarFromStyleValue Update style engine tests to cover bugfix in #43116 Moves style engine utils tests into correct directory
ramonjd
added a commit
that referenced
this pull request
Aug 15, 2024
Use style engine getCSSVarFromStyleValue Update style engine tests to cover bugfix in #43116 Moves style engine utils tests into correct directory
ramonjd
added a commit
that referenced
this pull request
Aug 15, 2024
#64490) Remove `compileStyleValue` in favour of pre-existing `getCSSValueFromRawStyle()` from the style engine package. Update style engine tests to cover bugfix in #43116 Moves style engine utils tests into correct directory Co-authored-by: ramonjd <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]> Co-authored-by: kevin940726 <[email protected]>
peterwilsoncc
pushed a commit
to peterwilsoncc/gutenberg-build
that referenced
this pull request
Sep 11, 2024
…g (#64490) Remove `compileStyleValue` in favour of pre-existing `getCSSValueFromRawStyle()` from the style engine package. Update style engine tests to cover bugfix in WordPress/gutenberg#43116 Moves style engine utils tests into correct directory Co-authored-by: ramonjd <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]> Co-authored-by: kevin940726 <[email protected]> Source: WordPress/gutenberg@add79ad
peterwilsoncc
pushed a commit
to peterwilsoncc/gutenberg-build
that referenced
this pull request
Sep 12, 2024
…g (#64490) Remove `compileStyleValue` in favour of pre-existing `getCSSValueFromRawStyle()` from the style engine package. Update style engine tests to cover bugfix in WordPress/gutenberg#43116 Moves style engine utils tests into correct directory Co-authored-by: ramonjd <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]> Co-authored-by: kevin940726 <[email protected]> Source: WordPress/gutenberg@add79ad
peterwilsoncc
pushed a commit
to peterwilsoncc/gutenberg-build
that referenced
this pull request
Sep 13, 2024
…g (#64490) Remove `compileStyleValue` in favour of pre-existing `getCSSValueFromRawStyle()` from the style engine package. Update style engine tests to cover bugfix in WordPress/gutenberg#43116 Moves style engine utils tests into correct directory Co-authored-by: ramonjd <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]> Co-authored-by: kevin940726 <[email protected]> Source: WordPress/gutenberg@add79ad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Regression after #43019.
RR fixes
uncompiledValue.startsWith is not a functionerror incompileStyleValue.Why?
Based on theme config the
uncompiledValuecan be an integer, and this causes an error.How?
Updated condition to check the uncompiledValue type.
Testing Instructions
I noticed the error when visiting the site editor using Stewart theme.
Screenshots or screencast