Lodash: Refactor away from _.startsWith()
#43019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
aristath,
gziolo,
swissspidy,
jorgefilipecosta,
chad1008,
andrewserong,
ntsekouras and
fabiankaegy
|
Size Change: +2 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
tyxla
force-pushed
the
remove/lodash-starts-with
branch
2 times, most recently
from
c063f8d to
40da6ca
Compare
ntsekouras
reviewed
Aug 8, 2022
packages/block-editor/src/components/link-control/is-url-like.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/link-control/use-search-handler.js
Outdated
Show resolved
Hide resolved
ntsekouras
approved these changes
Aug 9, 2022
Co-authored-by: Nik Tsekouras <[email protected]>
Co-authored-by: Nik Tsekouras <[email protected]>
tyxla
force-pushed
the
remove/lodash-starts-with
branch
from
7448102 to
b56633a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes the
_.startsWith()usage completely and deprecates the function.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
Removing
_.startsWith()is straightforward in favor of the nativeString.prototype.startsWith(), then we need to add additional optional chaining where the value may be nullish.Testing Instructions