Make the useDisabled hook stable #40890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] New API
|
Size Change: -18 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
adamziel
reviewed
May 6, 2022
gziolo
added
[Package] Block editor
youknowriad
force-pushed
the
add/use-disabled
branch
from
0263779
to
0b74ee1
Compare
youknowriad
force-pushed
the
add/use-disabled
branch
from
0b74ee1
to
208d061
Compare
ntsekouras
approved these changes
May 9, 2022
mtias
approved these changes
May 9, 2022
adamziel
approved these changes
May 9, 2022
mburridge
added
the
Needs Dev Note
|
Not sure if this needs a dev note for 6.1 release. Adding label just in case. |
|
@mburridge together with #40631 It might be a good Dev Note. What do you think @youknowriad |
|
This would be good as part of a general "new apis" dev note if there's such thing. On its own, it's pretty light. |
|
The part about useDisabled could be as follows. useDisabledIn some circumstances, such as block previews, all focusable DOM elements |
bph
added
has dev note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR just removes the "experimental" status from the useDisabled hook. The Disabled component has been around for some time now and this just makes it more easy to use without extra wrappers.
Testing Instructions
Nothing to test here really, there are no functional changes to the hook itself.