Improve the useDisabled hook and Disabled component #40631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
youknowriad
requested review from
ellatrix,
cameronvoell and
ajitbohra
as code owners
youknowriad
commented
Apr 26, 2022
| return useRefEffect( ( node ) => { | ||
| const disable = () => { | ||
| node.style.setProperty( 'user-select', 'none' ); | ||
| node.style.setProperty( '-webkit-user-select', 'none' ); |
There was a problem hiding this comment.
This change means you can select text inside a disabled element. For instance, I noticed that when double clicking a paragraph it would get selected even it had a "group" parent, that's because the "useSelectionObserver" hook would have triggered anyway. Preventing browser selection solves this.
There was a problem hiding this comment.
Do you mean whole block or just the text?
I would expect text to be selectable even if component is disabled. Mostly for copy/pasting.
There was a problem hiding this comment.
text as well. I'm not sure text should be selectable. Think patterns previews and stuff like that. Don't we want these things to behave more like "images".
Also, I'm not sure how I can fix the useSelectionObserver bug if I don't disable selection 😬
There was a problem hiding this comment.
I think disabling text selection for previews is okay, but will be more problematic UX decision for blocks in the editor.
There are few blocks that use Disabled component.
There was a problem hiding this comment.
The problem is that there's no way to know that a block is "disabled", it's not something in state. so there's no way to disabled useSelectionObserver when a block is disabled. So I'm not sure how to solve that otherwise.
There was a problem hiding this comment.
Good point 😅 I’m okay shipping the fix like this and keeping eye on the feedback.
There was a problem hiding this comment.
useSelectionObserver bug
That's a tricky one. What problem does this cause in practice?
There was a problem hiding this comment.
Right now in trunk "nothing" but I'm considering using useDisabled to disable blocks for several things:
- exploded mode
- block overlay (template parts and reusable blocks)
- potentially locking as well
The problem is that useSelectionObserver triggers, clicking a block will select it even if it's a child of a disabled block.
youknowriad
commented
Apr 26, 2022
| focusable instanceof | ||
| node.ownerDocument.defaultView.HTMLElement | ||
| ) { | ||
| focusable.style.setProperty( 'pointer-events', 'none' ); |
There was a problem hiding this comment.
This is another addition in this PR. Basically any clickable item inside the disabled element is now "non clickable"
youknowriad
commented
Apr 26, 2022
|
Size Change: -203 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
youknowriad
force-pushed
the
improve/use-disabled
branch
from
88a2241
to
468a006
Compare
|
Rebased this, so now it's just about adding stuff to useDisabled and use it in Disabled component. Should be ready for a ✅ |
ntsekouras
reviewed
Apr 27, 2022
Mamaduka
approved these changes
Apr 27, 2022
|
Ok let's try this. |
bph
added
the
Needs Dev Note
This was referenced Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The idea here is to improve useDisabled a bit in order to potentially use it for exploded mode or the block content overlay (template part, reusable blocks).
The PR also includes a small consolidation: I'm using the hook in the Disabled component instead of duplicating its code.
Why?
We need to figure out a way to disable block that is not fragile. Potentially we could leverage it for exploded mode.
How?
What I did to implement this is that I've used "useDisabled" in "useBlockProps" meaning all blocks would be disabled by default and I try selecting a container block (group) and I've tried to fixed all the cases where the child block would get selected anyway.
Note Right now when using the hook, it's a one way modification of the DOM, meaning we can restore a "non disabled" state and if we ever want to use the hook in exploded mode, we'd need a way to "restore" the enabled state. This behavior is not included in this PR.