[WIP] Post Template: Add click handler for switching between selected blocks when clicking on the block preview #37519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s when clicking on the block preview
andrewserong
added
the
[Type] Bug
|
Size Change: +62 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
|
Just adding a quick update of where this PR is at before I wrap up for the year (I'll be back in a couple of weeks): This PR seeks to enable clicking directly between blocks within the Query Loop post template and different instances of the loop. For example, if you currently have the Post Title selected within the loop, and then select the post excerpt from another instance of the loop (E.g. the next preview), then ideally we should immediately select that block, instead of moving focus to the parent container. The way we currently do that, is to switch off the
I'm not too sure what the solution is here — without switching off I've added a comment in #37154 (comment) as it sounds like there was a similar issue in the Comment Template block. |
This was referenced Feb 8, 2022
|
Closing out this PR now as it's quite stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🚧 🚧 🚧 🚧 🚧 🚧
Follows on from discussion in #37154 (comment) and #36431.
This is a WIP exploration PR at the moment, details TBC.
The goal is to ensure in the Post Template block, that when clicking between blocks within instances of the Query Loop, that when the block context is switched to another instance of the loop, we also change the selected block to the block that the user clicked on. This is to help it not feel like the user is dealing with a preview, but with a normal editor canvas.
How has this been tested?
TBC
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).