Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Excerpt Block: settings duplicated when selecting between different post excerpts in a Query Loop #40358

Closed
NidhiDhandhukiya74 opened this issue Apr 14, 2022 · 4 comments · Fixed by #40611
Assignees
Labels
[Block] Query Loop Affects the Query Loop Block [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended

Comments

@NidhiDhandhukiya74
Copy link

Description

In Query Loop block when you choose post excerpt and if you have multiple post so in different post when you click on that post excerpt it will add multiple settings in inspector control.

Step-by-step reproduction instructions

  1. Select Query Loop block.
  2. Click on the button start blank.
  3. Choose Title, Date, & Excerpt
  4. now from query loop choose post expert of any one post.
  5. Then choose post expert from another post.
  6. So each and every click will add a new setting in inspector control (Right side in settings of that block)
  7. and amongst that all setting only one is working other is not useful.

Screenshots, screen recording, code snippet

https://www.loom.com/share/34f6469686e0405cb13301e2819349b7

Environment info

WordPress 6.0 Beta 1, Gutenberg 13.0.0 and Twenty Twenty two theme.

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@ndiego ndiego added Needs Testing Needs further testing to be confirmed. [Type] Bug An existing feature does not function as intended labels Apr 15, 2022
@ndiego ndiego moved this from Triage to Todo in WordPress 6.0 Editor Tasks Apr 15, 2022
@ndiego ndiego added the [Block] Query Loop Affects the Query Loop Block label Apr 15, 2022
@ndiego
Copy link
Member

ndiego commented Apr 15, 2022

I am able to replicate this. I believe we need to tackle for 6.0 and have added it to the board.

@ndiego ndiego removed the Needs Testing Needs further testing to be confirmed. label Apr 15, 2022
@annezazu annezazu changed the title Query Loop block looks weird editor side and not behave proper if you choose Post Excerpt multiple times. Post Excerpt Block: settings duplicated when selecting between different post excerpts in a Query Loop Apr 18, 2022
@annezazu
Copy link
Contributor

Updated the title to make this a bit clearer and have included a screenshot below of how the settings duplicate/double when selecting between post excerpt options:

Screen Shot 2022-04-18 at 4 29 47 PM

@aaronrobertshaw aaronrobertshaw self-assigned this Apr 18, 2022
@aaronrobertshaw
Copy link
Contributor

I've done some digging into this.

To reliably replicate the bug, I needed to not only select the Post Excerpt but also click into the "read more" link within it, then select a new Post Excerpt. I believe this is where recent partial block selection updates might be causing a problem.

Git bisect appears to indicate the bug was introduced via #38892.

Demo - Before #38892

Commit: 5a71300

Screen.Recording.2022-04-19.at.4.39.56.pm.mp4
Demo - After #38892

Commit: 721e3c4

Screen.Recording.2022-04-19.at.4.37.29.pm.mp4

There were similar issues hit when attempting to add a click handler for switching between selected blocks when clicking on a block preview in #37519.

@ellatrix would you have any insights or thoughts on this issue? 🙏

I'm out of time today but will try and pick this up again in the next couple of days.

@ndiego ndiego added the [Priority] High Used to indicate top priority items that need quick attention label Apr 19, 2022
@annezazu
Copy link
Contributor

@mcsf tagging you in since I know Ella is out for a bit :)

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Apr 26, 2022
@ntsekouras ntsekouras moved this from Todo to In Progress in WordPress 6.0 Editor Tasks Apr 26, 2022
Repository owner moved this from In Progress to Done in WordPress 6.0 Editor Tasks Apr 27, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Query Loop Affects the Query Loop Block [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants